ruby - Share Variables between Methods in a Rails Controller -


i have rails controller has 2 methods. both methods use of same variables , i'm wondering how can refactor either method in model of somewhere in controller make them more reusable now.

class chartscontroller < applicationcontroller    before_filter :authenticate_user!, :company_id    def service_level     latest_date = invoice.where(:account_id => @company.accounts).maximum(:invc_date)     invoices_filter = { :invoices => { :invc_date => (latest_date - 3.months)..latest_date } }      invoices = invoice.where({:account_id => @company.accounts}.merge(invoices_filter))     details = invoicedetail.joins(:type).where(:invoice_id => invoices)     freight_details = details.where(:invoice_detail_types => { :category => 'freight' })      freight_groups = freight_details.group(:family).select("family, count(distinct package_id), sum(base_charge + discount)")       vol_data = {}     spend_data = {}      @charts = {}       @charts[:service_analysis] = {       :vol_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.count.to_i] }],       :spend_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.sum.to_f] }]     }      render partial: 'service_level'   end    def weight_summary      latest_date = invoice.where(:account_id => @company.accounts).maximum(:invc_date)     invoices_filter = { :invoices => { :invc_date => (latest_date - 3.months)..latest_date } }      invoices = invoice.where({:account_id => @company.accounts}.merge(invoices_filter))     details = invoicedetail.joins(:type).where(:invoice_id => invoices)     freight_details = details.where(:invoice_detail_types => { :category => 'freight' })     packages = freight_details.joins(:package, :invoice)        vol_data = {}     spend_data = {}     packages.group(:zone).select("zone, count(distinct package_id), sum(base_charge + discount)").each |row|       case row.zone         when '02'..'08', '002'..'008', '102'..'108', '132'..'138', '202'..'208', '242'..'248', '302'..'308'           zg = row.zone[-1]         when '09'..'17', '124'..'126', '224'..'226'           zg = 'ak/hi/pr'         else           zg = 'import/export'       end       vol_data[zg] = (vol_data[zg] || 0) + row.count.to_i       spend_data[zg] = (spend_data[zg] || 0) + row.sum.to_f     end     @charts = {}      @charts[:weight_analysis] = {       :vol_data => hash[(vol_data.sort_by {|key, value| key.scan(/\d+/)[0].to_i})],       :spend_data => hash[(spend_data.sort_by {|key, value| key.scan(/\d+/)[0].to_i})]     }       render partial: 'weight_summary'   end end

i suggest use model class method processing data. example

freight_details = details.where(:invoice_detail_types => { :category => 'freight' })  freight_groups = freight_details.group(:family).select("family, count(distinct package_id), sum(base_charge + discount)")   vol_data = {} spend_data = {}  @charts = {}   @charts[:service_analysis] = {   :vol_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.count.to_i] }],   :spend_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.sum.to_f] }] }

could moved model class method returns charts. in same way can refactor second method. kind of business logic , data proccessing should handled in models

moreover can see there many unused local variables there in controller. controller should thin as possible.


Comments

Post a Comment

Popular posts from this blog

basic authentication with http post params android -

i doing basic authentication passing username , password , using basicnamevaluepair sending post params response service. my method: public stringbuilder callservicehttppost(string username, string password, string type) { // create new httpclient , post header httpclient httpclient = new defaulthttpclient(); httppost httppost = new httppost(webservice + type); httpresponse response = null; stringbuilder total = new stringbuilder(); try { url url = new url(webservice + type); /*string base64encodedcredentials = base64.encodetostring((username + ":" + password).getbytes(), base64.url_safe | base64.no_wrap);*/ string base64encodedcredentials = "basic " + base64.encodetostring( (username + ":" + password).getbytes(), base64.no_wrap); httppost.setheader("auth...
Read more

vb.net - Virtual Keyboard commands -

i wondering difference between virtual these keyboard commands is: keyeventf_extendedkey , keyeventf_keyup is. everywhere have looked gives me description based off integers , not want know each of them does. you've tagged question vb.net, these have nothing @ vb.net. they're constants defined in windows header files, use win32 api functions. as far difference, can't tell looking @ values. individual values not particularly important, that's why named identifiers used. what's important used , documentation functions tells mean. the first one, keyeventf_extendedkey , used keybdinput structure (which used along e.g. sendinput function) pass information synthesized keyboard input. if flag used, means scan code should interpreted extended key. technically, means scan code preceded prefix byte value 224 (&he0 in hexadecimal notation). the second one, keyeventf_keyup , 1 of flags available use structure. means key being released (going up)...
Read more

How to get multiresult with multicondition in Sql Server -

i need solve this. hopefully can giving me advices. for sample, i've got data : proclib.march 1 first 10 rows flight date depart orig dest miles boarded capacity ----------------------------------------------------------------- 114 01mar94 7:10 lga lax 2475 172 210 202 01mar94 10:43 lga ord 740 151 210 219 01mar94 9:31 lga lon 3442 198 250 622 01mar94 12:19 lga fra 3857 207 250 132 01mar94 15:35 lga yyz 366 115 178 271 01mar94 13:17 lga par 3635 138 250 302 01mar94 20:22 lga 229 105 180 114 02mar94 7:10 lga lax 2475 119 210 202 02mar94 10:43 lga ord 740 120 210 219 02mar94 9:31 lga lon 344...
Read more