ruby - Share Variables between Methods in a Rails Controller -


i have rails controller has 2 methods. both methods use of same variables , i'm wondering how can refactor either method in model of somewhere in controller make them more reusable now.

class chartscontroller < applicationcontroller    before_filter :authenticate_user!, :company_id    def service_level     latest_date = invoice.where(:account_id => @company.accounts).maximum(:invc_date)     invoices_filter = { :invoices => { :invc_date => (latest_date - 3.months)..latest_date } }      invoices = invoice.where({:account_id => @company.accounts}.merge(invoices_filter))     details = invoicedetail.joins(:type).where(:invoice_id => invoices)     freight_details = details.where(:invoice_detail_types => { :category => 'freight' })      freight_groups = freight_details.group(:family).select("family, count(distinct package_id), sum(base_charge + discount)")       vol_data = {}     spend_data = {}      @charts = {}       @charts[:service_analysis] = {       :vol_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.count.to_i] }],       :spend_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.sum.to_f] }]     }      render partial: 'service_level'   end    def weight_summary      latest_date = invoice.where(:account_id => @company.accounts).maximum(:invc_date)     invoices_filter = { :invoices => { :invc_date => (latest_date - 3.months)..latest_date } }      invoices = invoice.where({:account_id => @company.accounts}.merge(invoices_filter))     details = invoicedetail.joins(:type).where(:invoice_id => invoices)     freight_details = details.where(:invoice_detail_types => { :category => 'freight' })     packages = freight_details.joins(:package, :invoice)        vol_data = {}     spend_data = {}     packages.group(:zone).select("zone, count(distinct package_id), sum(base_charge + discount)").each |row|       case row.zone         when '02'..'08', '002'..'008', '102'..'108', '132'..'138', '202'..'208', '242'..'248', '302'..'308'           zg = row.zone[-1]         when '09'..'17', '124'..'126', '224'..'226'           zg = 'ak/hi/pr'         else           zg = 'import/export'       end       vol_data[zg] = (vol_data[zg] || 0) + row.count.to_i       spend_data[zg] = (spend_data[zg] || 0) + row.sum.to_f     end     @charts = {}      @charts[:weight_analysis] = {       :vol_data => hash[(vol_data.sort_by {|key, value| key.scan(/\d+/)[0].to_i})],       :spend_data => hash[(spend_data.sort_by {|key, value| key.scan(/\d+/)[0].to_i})]     }       render partial: 'weight_summary'   end end

i suggest use model class method processing data. example

freight_details = details.where(:invoice_detail_types => { :category => 'freight' })  freight_groups = freight_details.group(:family).select("family, count(distinct package_id), sum(base_charge + discount)")   vol_data = {} spend_data = {}  @charts = {}   @charts[:service_analysis] = {   :vol_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.count.to_i] }],   :spend_data => hash[freight_groups.map { |row| [invoicedetailfamily[row.family].name, row.sum.to_f] }] }

could moved model class method returns charts. in same way can refactor second method. kind of business logic , data proccessing should handled in models

moreover can see there many unused local variables there in controller. controller should thin as possible.


Comments

Post a Comment

Popular posts from this blog

android - Inheriting from Theme.AppCompat* -

currently working on migrating actionbar in support libraries. trying migrate old themes inherit theme.appcompat.light.darkactionbar isn't going smoothly. it fine if apply theme in manifest such: <activity android:name="com.fitsby.loginactivity" android:screenorientation="portrait" android:theme="@style/theme.appcompat.light.darkactionbar" > </activity> but runtime error, stating loginactivity(subclass of actionbaractivity) must have theme inherits theme.appcompat, when following: in styles.xml: <style name="apptheme" parent="@style/theme.appcompat.light.darkactionbar"> <item name="android:typeface">sans</item> </style> and in manifest: <activity android:name="com.fitsby.loginactivity" android:screenorientation="portrait" android:theme="@style/apptheme" > </activity> any ideas why happening? not...
Read more

broadcastreceiver - android BOOT_COMPLETED not received if not activity intent-filter -

Image
i set simple app. wan't hide drawer , want add boot receiver launch service. to hide application, read had remove manifest <intent-filter> <action android:name="android.intent.action.main" /> <category android:name="android.intent.category.launcher" /> </intent-filter> but when remove it, boot receiver doesn't work anymore. i added permission under manifest tag <uses-permission android:name="android.permission.receive_boot_completed" /> and receiver under application <receiver android:name="com.example.receiver.bootreceiver" > <intent-filter> <action android:name="android.intent.action.boot_completed" /> </intent-filter> </receiver> and in receiver code, there toast public class bootreceiver extends broadcastreceiver { @override public void onreceive(context context, intent intent) { toast.maketext(context,...
Read more

basic authentication with http post params android -

i doing basic authentication passing username , password , using basicnamevaluepair sending post params response service. my method: public stringbuilder callservicehttppost(string username, string password, string type) { // create new httpclient , post header httpclient httpclient = new defaulthttpclient(); httppost httppost = new httppost(webservice + type); httpresponse response = null; stringbuilder total = new stringbuilder(); try { url url = new url(webservice + type); /*string base64encodedcredentials = base64.encodetostring((username + ":" + password).getbytes(), base64.url_safe | base64.no_wrap);*/ string base64encodedcredentials = "basic " + base64.encodetostring( (username + ":" + password).getbytes(), base64.no_wrap); httppost.setheader("auth...
Read more