How to run javascript image slideshow via external js file? -


i have slider on website ans working fine ... , image changer changes images on slide show , code written in main.html file this

<img src="images/1.jpg" name="slide"  width="100%" height="368" /> <script> <!--     var image1=new image()     image1.src="images/1.jpg"     var image2=new image()     image2.src="images/4.jpg"     var image3=new image()     image3.src="images/3.jpg"      //variable increment through images     var step=1     function slideit(){         //if browser not support image object, exit.         if (!document.images)             return         document.images.slide.src=eval("image"+step+".src")         if (step<3)             step++         else             step=1         //call function "slideit()" every 2.5 seconds         settimeout("slideit()",2500)     }     slideit() //--> </script>

now working absolutely fine.. want have file name page1.js want put javascript code in file instead of main.html file.. please tell me how put javascript code in page1.js file , call image slide show work fine working having javascript code in same file..

put javascript above file named my-slides.js, , replace script tag in current html file one:

<script type="text/javascript" src="my-slides.js"></script>

ensure my-slides.js in same folder html file, otherwise change path accordingly.

fwiw, although have not asked in question, think should mention following:

  • consider using curly braces define code blocks in if , else blocks, when single line. improves code readability
  • this line: document.images.slide.src=eval("image"+step+".src") uses eval , should avoid it. not sure accomplished here wrapping string concatenation eval. store images in array , access index instead.
  • rather have settimeout within function recur, consider using setinterval outside of function.

as requested.

this my-slides.js should contain.

    var numimages = 3;     var images = [];     (var = 0; < numimages; ++i) {         var image = new image();         image.src = 'images/' + (i + 1) + '.jpg';         images.push(image);     }      var step = 0;     function slideit() {         if (! document.images) {             return;         }         document.images.slide.src = images[step].src;         step = (step + 1) % numimages;     }     setinterval(slideit, 2500);

Comments

Post a Comment

Popular posts from this blog

basic authentication with http post params android -

i doing basic authentication passing username , password , using basicnamevaluepair sending post params response service. my method: public stringbuilder callservicehttppost(string username, string password, string type) { // create new httpclient , post header httpclient httpclient = new defaulthttpclient(); httppost httppost = new httppost(webservice + type); httpresponse response = null; stringbuilder total = new stringbuilder(); try { url url = new url(webservice + type); /*string base64encodedcredentials = base64.encodetostring((username + ":" + password).getbytes(), base64.url_safe | base64.no_wrap);*/ string base64encodedcredentials = "basic " + base64.encodetostring( (username + ":" + password).getbytes(), base64.no_wrap); httppost.setheader("auth...
Read more

vb.net - Virtual Keyboard commands -

i wondering difference between virtual these keyboard commands is: keyeventf_extendedkey , keyeventf_keyup is. everywhere have looked gives me description based off integers , not want know each of them does. you've tagged question vb.net, these have nothing @ vb.net. they're constants defined in windows header files, use win32 api functions. as far difference, can't tell looking @ values. individual values not particularly important, that's why named identifiers used. what's important used , documentation functions tells mean. the first one, keyeventf_extendedkey , used keybdinput structure (which used along e.g. sendinput function) pass information synthesized keyboard input. if flag used, means scan code should interpreted extended key. technically, means scan code preceded prefix byte value 224 (&he0 in hexadecimal notation). the second one, keyeventf_keyup , 1 of flags available use structure. means key being released (going up)...
Read more

c++ - End of file on pipe magic during open -

i have c++ application in starting process(wireshark) following. if (fp == null){ fp = popen(processpath, "r"); //processpath process want start if (!fp){ throw std::invalid_argument("cannot start process"); } fprintf(fp, d_msg);//d_msg input want provide process } else if(fp != null){ fprintf(fp, d_msg); } the problem when execute c++ application, start wireshark error end of file on pipe magic during open what should avoid that? also tried using mkfifo create named pipe , execute it. used this: if (fp == null){ system("mkfifo /tmp/mine.pcap"); fp = popen("wireshark -k -i /tmp/mine.pcap", "r"); if (!fp){ dout << "cannot start wireshark"<<std::endl; throw std::invalid_argument("cannot start wireshark"); } input = fopen("/tmp/mine.pcap", "wb"); fprintf(input , d_msg); fclose(input)...
Read more